-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sanitize rapl zone name #2301
sanitize rapl zone name #2301
Conversation
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
5c269cf
to
0cd26a7
Compare
Test? |
yeah ok adding |
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
Hmm, maybe this is one of those that we should make a label instead of mashing the metric name. |
@SuperQ any update on this ?? Do we need to fix this ?? |
@discordianfish What do you think? Should we move the rapl zone into a |
Here is the content of the relevant sysfs files from the machine that was a reason to fill the bug:
CPU: Maybe it will help. |
@discordianfish Will you share your kind opinion on this?
|
@SuperQ Yes, that would be cleaner. It's a breaking change though so I'm fine either way. |
@SuperQ @discordianfish Should I close this PR or we can go ahead with this? |
@sourikghosh Yes, let's use a label for this. |
hotfix for rapl collector crash sanitizing the rapl zone name for invalid metrics name.
closes #2299